Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPENG-2521: Implement the NIM service deployment page and connect it with the APIs #3

Conversation

yzhao583
Copy link
Collaborator

Description

JIRA: https://issues.redhat.com/browse/APPENG-2521

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

yzhao583 and others added 12 commits June 26, 2024 11:26
In order to run Cypress tests in CI (Jenkins) a designated Dockerfile
was added to /scripts/ci. It is based on Fedora 40 image (from Quay),
and it uses NVM (Node Version Manager) to install Node v20.
It is a rootless image that is supported to be running within Openshift
and Podman.

Building and Testing:

To build the Dockerfile with Podman, run for example:
`podman build --pull --rm -f "scripts/ci/Dockerfile" -t odh-cypress:latest ./`

You can find such image builds, including build logs in Quay:
https://quay.io/repository/nmanos/odh-dashboard?tab=builds

Once the image build completed, you can pull it, for example from Quay:
podman pull quay.io/nmanos/odh-dashboard:latest

The image can then be consumed within a CI framework, such as Jenkins,
that uses Containers for its execution runtime (e.g. with K8s plugin).

Within the container runtime you can git clone `odh-dashboard` and then
run 'frontend` Cypress tests (on the preinstalled Chrome). For example:

````
npm --verbose --prefix frontend ci")
npm --verbose run test:cypress-ci -- -s '**/application.cy.ts'"
```

The Cypress test results and the HTML report will be created as well.

Signed-off-by: manosnoam <[email protected]>
@yzhao583 yzhao583 self-assigned this Jul 16, 2024
@yzhao583 yzhao583 marked this pull request as ready for review July 29, 2024 20:04
@yzhao583 yzhao583 merged commit 0660dde into main Jul 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants